Add Product Element #14773
Merged
Add Product Element #14773
+1,278
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… colours for the product cards. Add the Product Card image component. Add the correct sizing to the Picture component for the new Product Image.
# Conflicts: # dotcom-rendering/src/types/content.ts
Closed
Merged
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
Co-authored-by: Jamie B <[email protected]>
Co-authored-by: Jamie B <[email protected]>
github-actions
bot
removed
the
run_chromatic
JamieB-gu
approved these changes
Nov 10, 2025
Contributor
JamieB-gu
left a comment
JamieB-gu
left a comment
There was a problem hiding this comment.
Looks good! One point about star-ratings, but that can be updated later as @oliverabrahams mentions.
github-actions
bot
removed
the
run_chromatic
github-actions
bot
removed
the
run_chromatic
|
Seen on PROD (merged by @oliverabrahams 8 minutes and 58 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Charley_Campbell [email protected]
Co-authored-by: Emma Imber [email protected]
What does this change?
ProductElementcomponent and corresponding storyrenderElementcodecontentWhy?
We have added a new Product element in Composer, which needs to be handled in the rendering layer. The point of this element is to provide a way of structuring product data in Filter articles. This structured data will unlock more design opportunities on Filter pages. Some more details are here if you're interested.
Screenshots
Screenshots are taken using our test article in CAPI CODE
Wide breakpoint
Mobile